Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable result cache by default #3244
Comments
sebastianbergmann
added
the
backward-compatibility-break
label
Aug 6, 2018
sebastianbergmann
added this to the PHPUnit 8.0 milestone
Aug 6, 2018
sebastianbergmann
referenced this issue
Aug 6, 2018
Closed
Do not create cache file by default #3237 #3241
This comment has been minimized.
This comment has been minimized.
shall we also change order execution to |
This comment has been minimized.
This comment has been minimized.
Makes sense. |
added a commit
that referenced
this issue
Nov 19, 2018
This comment has been minimized.
This comment has been minimized.
@epdenouden I started to work on this in 36ed9fe. One thing I noticed that if I run PHPUnit's own test suite with We probably have to disable the cache for all test suites executed by PHPUnit's own test suite. |
This comment has been minimized.
This comment has been minimized.
@sebastianbergmann Yes, unfortunately that is a known issue with (some of?) the PHPT tests. I have never looked that up in detail, however I am aware of it. The saving grace for PHPUnit's own test suite is that it overwrites the other caches at the end. I think at some point there was a development version that looked at the
In newer tests I actively work around the issue by explicitly copying the cache to a temporary file somewhere else and deleting it afterwards. This works really well; example: I am not sure what the best solution is that works in all cases, honestly. Wish I had a better answer for you already :-( |
sebastianbergmann commentedAug 6, 2018
No description provided.