You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
asserting that 2 arrays contains the same case-insensitive values without a constraint on the order (canonicalize + ignore case)
asserting that 2 arrays contains the same floats (with delta) without a constraint on the order (canonicalize + delta)
The new methods don't account for all combinations of it (and the comparator library still has them as optional parameters AFAICT, so these combinations would still be supported by the lower-level code, unless the goal is to change these APIs too)
I see your point, @stof. However, the combinatorial explosion made possible by mixing the various optional parameters of assertEquals() lead at least to confusion in the past. See #3317, for example. I would really like to reduce the complexity and confusion here. I am also not convinced that there are (enough) real use cases for the combinations to justify them.
I could see, however, keeping the $delta argument (somehow it feels "special") for assertEquals() and assertNotEquals() (removing the need for assertEqualsWithDelta() and assertNotEqualsWithDelta()) as well as adding $delta as an optional parameter to assertEqualsCanonicalizing() and assertNotEqualsCanonicalizing().
#3317 is not about assertEquals but about assertContains. AFAICT, ignoreCase should be working fine for arrays (in case they contain strings of course, otherwise there is no point for ignoring the case).