New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate optional parameters of assertEquals() and assertNotEquals() #3341

Open
sebastianbergmann opened this Issue Oct 11, 2018 · 0 comments

Comments

1 participant
@sebastianbergmann
Owner

sebastianbergmann commented Oct 11, 2018

These optional parameters of assertEquals() and assertNotEquals() should be deprecated:

  • $delta (use assertEqualsWithDelta() or assertNotEqualsWithDelta() from #3340 instead)
  • $maxDepth (respective functionality was removed)
  • $canonicalize (use assertEqualsCanonicalizing() or assertNotEqualsCanonicalizing() from #3340 instead)
  • $ignoreCase (use assertEqualsIgnoringCase() or assertNotEqualsIgnoringCase() from #3340 instead)

@sebastianbergmann sebastianbergmann added this to the PHPUnit 8.0 milestone Oct 11, 2018

@sebastianbergmann sebastianbergmann self-assigned this Oct 11, 2018

sebastianbergmann added a commit that referenced this issue Oct 11, 2018

sebastianbergmann added a commit that referenced this issue Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment