-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
printerClass
deprecated on PHPUnit 10
#4807
Comments
This is not a deprecation, this is a removal. Everything related to this has been removed (or will be removed by the time PHPUnit 10 is released).
All output, to the console as well as to logfiles etc., in PHPUnit 10 will be event-based. While the initial work on the event system itself is complete, we are currently in the process of migrating all internal functionality of PHPUnit to it. For instance, the JUnit XML logging has already been migrated. The TeamCity logging will be next. PHPUnit's own console printer(s) come(s) after that. Once we have migrated all internal functionality of PHPUnit from I am closing this issue now and kindly ask you ask additional questions on #4676. I promise to let you know when we are ready for projects such as Pest to experiment with the event system, but we are just not there yet. |
Thank you for the feedback. 👍🏻 |
Thank you Sebastian. I'm interested in the same stuff, and I started working on the same migration in facile-it/paraunit#162. The new event system is great and I was able to monkey patch into it leveraging So, if we want to make this happen sooner, the only think we can do is help with the migration of the other internal features, right? I'll see if I can do something about it. |
I see that there's already https://github.com/sebastianbergmann/phpunit/compare/issue-4699/refactor-teamcity-logger-to-use-events @sebastianbergmann where can we help? |
Thank you for offering to help. I will get back to you once I know what I can delegate and how. |
@sebastianbergmann I've already migrated Pest ( except the printer stuff ) to the new Event system in a development branch. The new event stuff is awesome, I didn't extend a single class. 👏🏻 |
Wow!, that is great to hear. Thanks for sharing! |
Glad to hear that it works well for you! |
@nunomaduro sounds great! Was looking for a PR for inspiration, but it probably isn't pestphp/pest#263 that I was looking for. Could you share some of your insights? For paraunit this PR looks great already: https://github.com/facile-it/paraunit/pull/162/files |
On the PHPUnit 10 changelog, I've just saw the following entry:
At Laravel, and Pest PHP, we use this option to provider our own printer. Any workaround? If not, could you consider to revert this deprecation? Thank you!
The text was updated successfully, but these errors were encountered: