Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Don't call PHP_CodeCoverage_Filter::addDirectoryToBlacklist and File when code coverage is not invoked #69

Closed
ped7g opened this Issue · 1 comment

2 participants

@ped7g

enhancement

The add to black list family of functions is performance wise very very slow, takes well over 0.5sec on my machine.

Either make those calls optional only when --coverage is used, or implement the regexp pull request from johncrenshaw, and change the phpunit source to use regexp instead.

(I would suggest to add regexp solution, because it will improve performance even for code coverage running, not just for a run without code coverage)

@edorian
Collaborator

No matter what it seems to be a good idea to only blacklist when needed. I'm going to chance that for now and whatever happens/happed with the pull request will be a separate issue i guess :)

@edorian edorian closed this in 4924661
@greglamb greglamb referenced this issue from a commit in greglamb/phpunit
@edorian edorian Closes #69. Only act upon the blacklist/whistelist configuration when…
… it is necessary
d0a4147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.