assertSelectCount fails with plus selector #869

Closed
filipiz opened this Issue Mar 27, 2013 · 3 comments

Comments

2 participants

filipiz commented Mar 27, 2013

I think the plus selector is missing.
I took a fast look on PHPUnit_Util_XML::convertSelectToTag method and couldn't identify it there.

I would like to assert if the HTML elements are on the proper order.
Is there any way to do that kind of assertion without having to use string equality?

Contributor

whatthejeff commented Mar 28, 2013

Yeah, it looks like PHPUnit_Util_XML::convertSelectToTag() doesn't understand adjacent sibling selectors. I might have some time for this in the coming weekend unless you'd be interested in providing a PR.

filipiz commented Mar 28, 2013

I would really enjoy to contribute to the project but unfortunatelly I won't be able code do anything before the next week.

@ghost ghost assigned whatthejeff Apr 1, 2013

Contributor

whatthejeff commented Apr 1, 2013

The adjacent sibling selector (+) is now supported in the master branch. I was going to add support for the general sibling selector (~), but I ran into #878. Hopefully we can have that straightened out soonish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment