include_path_refactor #118

Merged
1 commit merged into from Jan 16, 2011

Conversation

Projects
None yet
1 participant
Collaborator

whatthejeff commented Jan 16, 2011

I believe #104 and #64 reference a similar issue. While PHPUnit_Util_Fileloader::checkAndLoad() is intended to use the include_path in all cases I've found, it actually only checks $filename and ./$filename. Then, if the file is not readable, PHPUnit prints an error message saying "Cannot open file ./$filename." This can be especially confusing if the user has provided an absolute path. For example, the error message from #64 is:

Cannot open file "./c:\Program Files\Apache Software Foundation\Apache2.2\htdocs\domspl\test\phpunit\unit\lib\UnitTestSuite.php".
@whatthejeff whatthejeff `PHPUnit_Util_Fileloader::checkAndLoad()` now uses the `include_path`
`PHPUnit_Util_Fileloader::checkAndLoad()` errors show the original filename instead of a name prepended with ./
The bootstrap is no longer loaded in two places.
983eaa8

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment