Fix: serialization of test suits static properties #1208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When --backupStaticAttributes switch is set static properties of classes derived from PHPUnit_Framework_Test are also backed up due to wrong use of instanceof. <string> instanceof <object>|<class>|<string> is always false. One should use is_a(<stringClassName>, <stringClassName>, true). This bug affect all versions of PHPUnit that uses PHPUnit_Util_GlobalState class.
|
Your patch is not compatible with PHP 5.3.3 (see Travis). |
is_a in PHP 5.3.3 does not support third parameter (allow_string) thus $object parameter cannot be string.
|
Cherry-picked into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When --backupStaticAttributes switch is set, static properties of classes derived from PHPUnit_Framework_Test are also backed up due to wrong use of instanceof.
string instanceof object|class|string is always false. One should use is_a(stringClassName, stringClassName, true).
This bug affect all versions of PHPUnit that uses PHPUnit_Util_GlobalState class.