Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insulated tests with phpdbg #1956

Merged
merged 1 commit into from Nov 17, 2015
Merged

Fix insulated tests with phpdbg #1956

merged 1 commit into from Nov 17, 2015

Conversation

@nicolas-grekas
Copy link
Contributor

@nicolas-grekas nicolas-grekas commented Nov 17, 2015

Fixes #1955

@GrahamCampbell
Copy link
Sponsor Contributor

@GrahamCampbell GrahamCampbell commented Nov 17, 2015

Nice fix. 👍

@sebastianbergmann
Copy link
Owner

@sebastianbergmann sebastianbergmann commented Nov 17, 2015

Thanks. I do think, though, that this should go into the Runtime class. Or?

@nicolas-grekas
Copy link
Contributor Author

@nicolas-grekas nicolas-grekas commented Nov 17, 2015

It could but it's not trivial: -d options needs to be before the eval-stdin.php on the command line, which means that simple concatenation doesn't work...

@sebastianbergmann
Copy link
Owner

@sebastianbergmann sebastianbergmann commented Nov 17, 2015

Okay. Sounds like one more reason to work on #1342 then.

@sebastianbergmann sebastianbergmann merged commit 3aaddb1 into sebastianbergmann:4.8 Nov 17, 2015
1 check passed
@nicolas-grekas nicolas-grekas deleted the phpdbg branch Nov 18, 2015
@bwoebi
Copy link
Contributor

@bwoebi bwoebi commented Nov 13, 2016

This, … well https://bugs.php.net/73484

This doesn't fix the bug, it just ends up not running the tests at all due to the use of php://input instead of php://stdin.

@sebastianbergmann
Copy link
Owner

@sebastianbergmann sebastianbergmann commented Nov 13, 2016

Pull requests welcome! :-)

Truth be told, neither process isolation nor PHPDBG compatibility are high priority topics for me.

bwoebi added a commit to bwoebi/phpunit that referenced this issue Nov 13, 2016
@bwoebi
Copy link
Contributor

@bwoebi bwoebi commented Nov 13, 2016

Yeah, see #2356 ;-)

sebastianbergmann added a commit that referenced this issue Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants