Fix bug when replacing placeholders in testdox using an associative array #3398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
At Croct we usually assign keys to data provider arguments to improve code readability:
It works fine in all cases except when the
@testdox
has placeholders. In this case you will get an error:There is also a bug when omitting optional parameters in data providers:
Warning:
This PR includes the fixes and tests for both scenarios.