Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reverse order test failures #3402

Conversation

epdenouden
Copy link
Contributor

Listening to the tests in reverse revealed evil hidden messages 馃

This test makes sure that the configuration file cannot override system
environment settings by using putenv(). This is not restored by the
backupGlobals system, causing another configuration test to fail.

Obviously this could have been fixed by using a variable name other than
 'foo', but I'll like having this here as a reminder of the dependency
 on putenv/getenv.
@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

Merging #3402 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3402   +/-   ##
=========================================
  Coverage     83.05%   83.05%           
  Complexity     3570     3570           
=========================================
  Files           143      143           
  Lines          9503     9503           
=========================================
  Hits           7893     7893           
  Misses         1610     1610

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update bdeb99a...3dbb52b. Read the comment docs.

@sebastianbergmann
Copy link
Owner

Merged into 7.4, thanks.

@epdenouden epdenouden deleted the fix-reverse-order-test-failures branch November 26, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants