Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ErrorHandler #3616

Closed
wants to merge 1 commit into from
Closed

Clean up ErrorHandler #3616

wants to merge 1 commit into from

Conversation

Funfare
Copy link

@Funfare Funfare commented Apr 26, 2019

cleans up error handler as requested in #3503

TestCase was extended to controll behavior of error handler

$this->convertErrorsToExceptions(false);
$this->convertDeprecationsToExceptions(false);
$this->convertNoticesToExceptions(false);
$this->convertWarningsToExceptions(false);

@oliverklee
Copy link
Sponsor Contributor

@FunfareNico To fix the build, you can run this and then re-push:

./tools/php-cs-fixer fix

@sebastianbergmann sebastianbergmann added the event/code-sprint/2019-04 PHPUnit Code Sprint: April 2019 label Apr 28, 2019
@sebastianbergmann
Copy link
Owner

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event/code-sprint/2019-04 PHPUnit Code Sprint: April 2019
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants