Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix unescaped dash in character group in regex #3723

Merged
merged 1 commit into from Jun 15, 2019

Conversation

@mvorisek
Copy link
Contributor

commented Jun 14, 2019

No description provided.

@codecov

This comment has been minimized.

Copy link

commented Jun 14, 2019

Codecov Report

Merging #3723 into 7.5 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                7.5    #3723   +/-   ##
=========================================
  Coverage     83.38%   83.38%           
  Complexity     3646     3646           
=========================================
  Files           143      143           
  Lines          9714     9714           
=========================================
  Hits           8100     8100           
  Misses         1614     1614
Impacted Files Coverage Δ Complexity Δ
src/Util/Test.php 94.1% <ø> (ø) 217 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a5c2f...38f0daf. Read the comment docs.

@sebastianbergmann

This comment has been minimized.

Copy link
Owner

commented Jun 15, 2019

Can you please elaborate what you intend to fix with this change? Thanks!

@mvorisek

This comment has been minimized.

Copy link
Contributor Author

commented Jun 15, 2019

PHP 7.3 uses newer POSIX regex engine and regexes like ~[\d-_]~ became invalid. The fixed regex may became invalid someday too, so I fixed it. - as character is safe to use only as regular range operator or when it is placed the most left or the most right in the character group.

@sebastianbergmann sebastianbergmann merged commit d6e5300 into sebastianbergmann:7.5 Jun 15, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 56a5c2f...38f0daf
Details
codecov/project 83.38% remains the same compared to 56a5c2f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.