Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test class run in a separate PHP process are passing when "exit" called inside #3968

Merged
merged 3 commits into from Dec 5, 2019
Merged

Test class run in a separate PHP process are passing when "exit" called inside #3968

merged 3 commits into from Dec 5, 2019

Conversation

@kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Dec 4, 2019

  • adding a test with incorrect behaviour
  • updating the test with expected behaviour
  • adding fix
@codecov
Copy link

@codecov codecov bot commented Dec 4, 2019

Codecov Report

Merging #3968 into 7.5 will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##                7.5    #3968     +/-   ##
===========================================
+ Coverage     83.49%   83.59%   +0.1%     
- Complexity     3652     3653      +1     
===========================================
  Files           143      143             
  Lines          9744     9749      +5     
===========================================
+ Hits           8136     8150     +14     
+ Misses         1608     1599      -9
Impacted Files Coverage Δ Complexity Δ
src/Util/PHP/AbstractPhpProcess.php 72.6% <100%> (+0.97%) 41 <0> (+1) ⬆️
src/Runner/Version.php 66.66% <0%> (ø) 8% <0%> (ø) ⬇️
src/Framework/TestResult.php 75.85% <0%> (+2.19%) 170% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81b7b0e...7f82eb4. Read the comment docs.

Loading

@sebastianbergmann sebastianbergmann merged commit afb88b4 into sebastianbergmann:7.5 Dec 5, 2019
11 checks passed
Loading
@pitbulk pitbulk mentioned this pull request Dec 28, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants