Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loading PHPUnit extensions via command-line options #4136

Merged

Conversation

@Jean85
Copy link
Contributor

Jean85 commented Mar 9, 2020

This is WIP, opening for feedback and looking at CI results.

This attempts to implement #4131. Ready for review now.

Jean85 added 3 commits Mar 9, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #4136 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4136      +/-   ##
============================================
- Coverage     83.68%   83.66%   -0.03%     
- Complexity     4484     4488       +4     
============================================
  Files           218      218              
  Lines         10994    11005      +11     
============================================
+ Hits           9200     9207       +7     
- Misses         1794     1798       +4
Impacted Files Coverage Δ Complexity Δ
src/TextUI/Help.php 100% <ø> (ø) 25 <0> (ø) ⬇️
src/TextUI/Arguments/Arguments.php 69% <100%> (+0.16%) 325 <82> (+1) ⬆️
src/TextUI/Arguments/ArgumentsMapper.php 80% <100%> (+0.13%) 74 <0> (ø) ⬇️
src/TextUI/Arguments/ArgumentsBuilder.php 79.64% <40%> (-0.52%) 109 <0> (+2)
src/TextUI/TestRunner.php 63.52% <50%> (-0.05%) 210 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279faa2...eadb8c8. Read the comment docs.

@Jean85

This comment has been minimized.

Copy link
Contributor Author

Jean85 commented Mar 10, 2020

I tested this with facile-it/paraunit#149, and it works!

That PR is a long way to be fully functional, but with this simple change it's starting to run: facile-it/paraunit@2919622#diff-6fad06c8b70bf58250bc1c7b628bdcf6R38-R47

Removing WIP, ready to review.

@Jean85 Jean85 marked this pull request as ready for review Mar 10, 2020
@sebastianbergmann sebastianbergmann merged commit fc9444b into sebastianbergmann:master Mar 10, 2020
9 of 12 checks passed
9 of 12 checks passed
Coding Guidelines
Details
Type Checker Type Checker
Details
Backward Compatibility
Details
Lint XML Configuration
Details
Tests (7.3, lowest)
Details
Tests (7.3, highest)
Details
Tests (7.4, lowest)
Details
Tests (7.4, highest)
Details
Tests (8.0, lowest)
Details
Tests (8.0, highest)
Details
codecov/patch 66.66% of diff hit (target 83.68%)
Details
codecov/project 83.66% (+-0.03%) compared to 279faa2
Details
@sebastianbergmann sebastianbergmann added this to the PHPUnit 9.1 milestone Mar 10, 2020
@sebastianbergmann sebastianbergmann changed the title Add --extensions CLI option Allow loading PHPUnit extensions via command-line options Mar 10, 2020
@Jean85 Jean85 deleted the Jean85:add-extensions-cli-option branch Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.