Support for Cobertura XML report format#4462
Support for Cobertura XML report format#4462smmccabe wants to merge 2 commits intosebastianbergmann:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4462 +/- ##
============================================
- Coverage 85.26% 85.14% -0.13%
- Complexity 4514 4532 +18
============================================
Files 243 245 +2
Lines 12372 12424 +52
============================================
+ Hits 10549 10578 +29
- Misses 1823 1846 +23
Continue to review full report at Codecov.
|
|
Figured out the type checker issue, fixed. |
|
Oh wow nice! Just discovered a new feature in GitLab that needs the cobertura report (https://about.gitlab.com/releases/2020/09/22/gitlab-13-4-released/#inline-code-coverage-remarks-inside-mr-diffs). Gonna try this out the next days 😈 |
|
@DanielBadura did you try this feature? @sebastianbergmann Looks like you closed this PR. Any special reason to not include this feature? Thank you. |
|
Yeah it tried to try it :D its not just closed, the feature is in phpunit ;o |
Cobertura options to for once sebastianbergmann/php-code-coverage#812 gets merged in.
There is 1 type check failing that I don't understand. It references a method that hasn't been changed with this patch so I am unclear as to why it is failing now and doesn't on master. I haven't used psalm before though so maybe I am just missing something.