Print exception cause master #586

Merged
merged 3 commits into from Jul 27, 2012

2 participants

@matheusd

Removed check for php 5.3 and added TextUi test as per sebastianbergmann/phpunit#571

@matheusd

By the way, I couldn't run the full test suite on phpunit. It hangs at the test regression/github/244. I'm running on a windows platform.

@edorian
Collaborator

Thanks for the pull request. I'll get around to checking it out in the next couple of days. I'll need to look into the windows test suite too. It might be a problem on our part.

@edorian
Collaborator

He @matheusd. I've looked over the patch and it look ok so far.

I think it would make sense to loop on the previous exception printing the whole stack?

For the failing tests: It seems to work for me but just delete the regression folder if you run into issues there.

If you fix up the test (and maybe add the loop if you want and another test for this) i think this would be a great addition to phpunit :)

@edorian edorian added a commit that referenced this pull request Jul 27, 2012
@edorian edorian Changelog for #586 f302d73
@edorian edorian merged commit e3ea6c0 into sebastianbergmann:master Jul 27, 2012
@edorian
Collaborator

Thanks a bunch!

@edorian edorian added a commit that referenced this pull request Sep 12, 2012
@edorian edorian Adapted test after #586 changed the output 0470567
@greglamb greglamb pushed a commit to greglamb/phpunit that referenced this pull request Apr 19, 2013
@edorian edorian Added exception and message to previous exceptions and cleaned up #586 fe39bd5
@greglamb greglamb pushed a commit to greglamb/phpunit that referenced this pull request Apr 19, 2013
@edorian edorian Changelog for #586 946b96f
@greglamb greglamb pushed a commit to greglamb/phpunit that referenced this pull request Apr 19, 2013
@edorian edorian Adapted test after #586 changed the output 61c9bf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment