New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print exception cause master #586

Merged
merged 3 commits into from Jul 27, 2012

Conversation

2 participants
@matheusd
Contributor

matheusd commented Jun 8, 2012

Removed check for php 5.3 and added TextUi test as per sebastianbergmann/phpunit#571

@matheusd

This comment has been minimized.

Show comment
Hide comment
@matheusd

matheusd Jun 8, 2012

Contributor

By the way, I couldn't run the full test suite on phpunit. It hangs at the test regression/github/244. I'm running on a windows platform.

Contributor

matheusd commented Jun 8, 2012

By the way, I couldn't run the full test suite on phpunit. It hangs at the test regression/github/244. I'm running on a windows platform.

@edorian

This comment has been minimized.

Show comment
Hide comment
@edorian

edorian Jun 12, 2012

Contributor

Thanks for the pull request. I'll get around to checking it out in the next couple of days. I'll need to look into the windows test suite too. It might be a problem on our part.

Contributor

edorian commented Jun 12, 2012

Thanks for the pull request. I'll get around to checking it out in the next couple of days. I'll need to look into the windows test suite too. It might be a problem on our part.

@edorian

This comment has been minimized.

Show comment
Hide comment
@edorian

edorian Jul 2, 2012

Contributor

He @matheusd. I've looked over the patch and it look ok so far.

I think it would make sense to loop on the previous exception printing the whole stack?

For the failing tests: It seems to work for me but just delete the regression folder if you run into issues there.

If you fix up the test (and maybe add the loop if you want and another test for this) i think this would be a great addition to phpunit :)

Contributor

edorian commented Jul 2, 2012

He @matheusd. I've looked over the patch and it look ok so far.

I think it would make sense to loop on the previous exception printing the whole stack?

For the failing tests: It seems to work for me but just delete the regression folder if you run into issues there.

If you fix up the test (and maybe add the loop if you want and another test for this) i think this would be a great addition to phpunit :)

edorian added a commit that referenced this pull request Jul 27, 2012

@edorian edorian merged commit e3ea6c0 into sebastianbergmann:master Jul 27, 2012

@edorian

This comment has been minimized.

Show comment
Hide comment
@edorian

edorian Jul 27, 2012

Contributor

Thanks a bunch!

Contributor

edorian commented Jul 27, 2012

Thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment