required PHPUnit_Utils_Filesystem in Autoload #605

Closed
wants to merge 1 commit into
from

Conversation

2 participants

cebe commented Jul 15, 2012

added this line because this file is using the class and there might be
an autoloader that tries to include it before phpunit can do it.
workarounds are not possible outside of this file though.

required PHPUnit_Utils_Filesystem in Autoload
added this line because this file is using the class and there might be
an autoloader that tries to include it before phpunit can do it.
workarounds are not possible outside of this file though.

@cebe cebe referenced this pull request in yiisoft/yii Jul 15, 2012

Closed

build command seems to require phpunit installed #963

cebe added a commit to cebe/yii that referenced this pull request Jul 15, 2012

fixed PHPUnit autoloading
- removed requirement for PHPUnit from build command #963
- fixed PHPUnit autoloading in CTestCase
  register phpunit autoloader before Yii autoloader to handle phpunit
  autoloads correctly.
  Also require PHPUnit/Util/Filesystem.php to avoid Yii autoloader to
  crash initializing of PHPUnit autoloader, see also:
  sebastianbergmann/phpunit#605
  sebastianbergmann/phpunit#605
- imported CTestCase in CWebTestCase to ensure PHPUnit autoloader is
  initialized correctly

@cebe cebe referenced this pull request in yiisoft/yii Jul 15, 2012

Merged

fixed PHPUnit autoloading #976

cebe commented Sep 7, 2012

@sebastianbergmann any comment, why you are closing this!?
This issue is valid as when there is an other autoloader already registered we are not able to include PHPUnit autoloader and adjust the order of autoloaders afterwards as it tries to load that PHPUnit_Utils_Filesystem class.
I think it is very clear what this issue is about, if not, please ask me instead of just closing it...

cebe commented Sep 7, 2012

Btw: example of using phpunit autoloader like this: https://github.com/yiisoft/yii/pull/976/files#diff-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment