Base test listener #838

Merged
merged 4 commits into from Mar 10, 2013

Conversation

Projects
None yet
2 participants
Contributor

giorgiosironi commented Feb 24, 2013

Solves #814

giorgiosironi added some commits Feb 24, 2013

@giorgiosironi giorgiosironi Added BaseTestListener class 5246b41
@giorgiosironi giorgiosironi [00;36mBuildfile: /home/giorgio/code/phpunit/build.xml[m
[00;32m
PHPUnit > phpab:
[m
phpab 1.10.2 - Copyright (C) 2009 - 2013 by Arne Blankerts

Scanning directory PHPUnit

Autoload file PHPUnit/Autoload.php generated.

[00;32m
BUILD FINISHED

Total time: 2.4655 seconds
[m prints its result for easy debugging
0c1497f
Collaborator

whatthejeff commented Mar 7, 2013

Could you revert 0c1497f (it's not exactly related to #814)? After that, I'll gladly merge this PR.

Collaborator

whatthejeff commented Mar 7, 2013

Also, do you think you'd have time to add an entry about this test listener to the docs?

@whatthejeff whatthejeff commented on an outdated diff Mar 9, 2013

PHPUnit/Framework/BaseTestListener.php
+ */
+
+/**
+ * An empty Listener that can be extended to implement TestListener
+ * with just a few lines of code.
+ * @see PHPUnit_Framework_TestListener for documentation on the API methods.
+ *
+ * @package PHPUnit
+ * @subpackage Framework
+ * @author Giorgio Sironi<info@giorgiosironi.com>
+ * @copyright 2001-2013 Sebastian Bergmann <sebastian@phpunit.de>
+ * @license http://www.opensource.org/licenses/BSD-3-Clause The BSD 3-Clause License
+ * @link http://www.phpunit.de/
+ * @since Class available since Release 3.8.0
+ */
+class PHPUnit_Framework_BaseTestListener implements PHPUnit_Framework_TestListener
@whatthejeff

whatthejeff Mar 9, 2013

Collaborator

Shouldn't this class be abstract?

Contributor

giorgiosironi commented Mar 10, 2013

Thank you for your feedback, I've fixed the two issues. I will open a separate PR for the documentation since it's another repository.

giorgiosironi referenced this pull request in sebastianbergmann/phpunit-documentation Mar 10, 2013

Merged

Documentation for BaseTestListener abstract class #90

@whatthejeff whatthejeff added a commit that referenced this pull request Mar 10, 2013

@whatthejeff whatthejeff Merge pull request #838 from giorgiosironi/base_test_listener
Base test listener
a36f92f

@whatthejeff whatthejeff merged commit a36f92f into sebastianbergmann:master Mar 10, 2013

1 check passed

default The Travis build passed
Details
Collaborator

whatthejeff commented Mar 10, 2013

Thanks, @giorgiosironi!

@whatthejeff whatthejeff added a commit that referenced this pull request Mar 10, 2013

@whatthejeff whatthejeff Changelog and cleanup from #838. e370307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment