Critical issue on empty --limit option #75

Closed
sebastianfeldmann opened this Issue Dec 4, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@sebastianfeldmann
Owner

sebastianfeldmann commented Dec 4, 2016

var_dump(explode(',', ''));
prints the following output:

array(1) {
[0]=>
string(0) ""
}
therefore limit is never empty during the $configuration->isBackupActive() check, which leads to phpbu currently skipping all backups if you don't explicitly set the limit-option.

checking if the limit option is empty before explode'ing will fix the issue.

@sebastianfeldmann sebastianfeldmann self-assigned this Dec 4, 2016

@sebastianfeldmann

This comment has been minimized.

Show comment
Hide comment
@sebastianfeldmann

sebastianfeldmann Dec 4, 2016

Owner

Fixed in version 4.0.3 thanks to @arkste

Owner

sebastianfeldmann commented Dec 4, 2016

Fixed in version 4.0.3 thanks to @arkste

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment