Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical issue on empty --limit option #75

Closed
sebastianfeldmann opened this issue Dec 4, 2016 · 1 comment
Closed

Critical issue on empty --limit option #75

sebastianfeldmann opened this issue Dec 4, 2016 · 1 comment
Assignees
Labels
bug

Comments

@sebastianfeldmann
Copy link
Owner

@sebastianfeldmann sebastianfeldmann commented Dec 4, 2016

var_dump(explode(',', ''));
prints the following output:

array(1) {
[0]=>
string(0) ""
}
therefore limit is never empty during the $configuration->isBackupActive() check, which leads to phpbu currently skipping all backups if you don't explicitly set the limit-option.

checking if the limit option is empty before explode'ing will fix the issue.

@sebastianfeldmann sebastianfeldmann self-assigned this Dec 4, 2016
@sebastianfeldmann
Copy link
Owner Author

@sebastianfeldmann sebastianfeldmann commented Dec 4, 2016

Fixed in version 4.0.3 thanks to @arkste

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.