Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Cli.php: Altering detectCmdLocationInPaths() to check $bin variable as non-empty string instead of non-null value. #125
The isExecutable() method returns a string and in almost all of the places it's used, its return value is checked as empty/nonempty string. But the detectCmdLocationInPaths() usage checks for a non-null value.
This discrepancy is to causing my installs to not find system tools like mysqldump and gzip. The for() loop in detectCmdLocationInPaths() is ending too early (after only one iteration) and doesn't check all locations in the system path.
I've changed the detectCmdLocationInPaths() method to check the return value of isExecutable() as a string.
The isExecutable() method returns a string and almost all uses of the method check the return value with the empty() method. This commit changes detectCmdLocationInPaths() to also test the returned value as a string.