Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(influxdb): add influxdb backup support #198

Merged

Conversation

@angelfs
Copy link
Contributor

@angelfs angelfs commented Aug 21, 2019

No description provided.

@sebastianfeldmann sebastianfeldmann self-requested a review Aug 21, 2019
@sebastianfeldmann
Copy link
Owner

@sebastianfeldmann sebastianfeldmann commented Aug 21, 2019

Thanks for the implementation.

It looks great but I found some small issues that cause the unit tests to fail.
Would be great if you code fix those before I merge the PR :)

$appResult->expects($this->once())->method('debug');

$influxd = new Influxdump($runner);
$influxd->setup(['pathToInfluxDb' => PHPBU_TEST_BIN]);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pathToInfluxDb should be pathToInfluxdump

Copy link
Contributor Author

@angelfs angelfs Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I solved this when I had running the test but I forgot to add in GIT...
Problem fix now.

$appResult->expects($this->once())->method('debug');

$influxd= new Influxdump($runner);
$influxd->setup(['pathToInfluxDb' => PHPBU_TEST_BIN]);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pathToInfluxDb should be pathToInfluxdump

$appResult->expects($this->once())->method('debug');

$influxd = new Influxdump($runner);
$influxd->setup(['pathToInfluxDb' => PHPBU_TEST_BIN]);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pathToInfluxDb should be pathToInfluxdump

@angelfs angelfs force-pushed the feat/source-influxdb branch from c6754e7 to 5c4c9ae Aug 22, 2019
Copy link
Owner

@sebastianfeldmann sebastianfeldmann left a comment

Nice work! Thanks

@sebastianfeldmann sebastianfeldmann merged commit 1beb90a into sebastianfeldmann:master Aug 22, 2019
1 of 2 checks passed
@angelfs angelfs deleted the feat/source-influxdb branch Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants