Feat(influxdb): add influxdb backup support #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the implementation. It looks great but I found some small issues that cause the unit tests to fail. |
sebastianfeldmann
requested changes
Aug 21, 2019
| $appResult->expects($this->once())->method('debug'); | ||
|
|
||
| $influxd = new Influxdump($runner); | ||
| $influxd->setup(['pathToInfluxDb' => PHPBU_TEST_BIN]); |
There was a problem hiding this comment.
pathToInfluxDb should be pathToInfluxdump
There was a problem hiding this comment.
My bad, I solved this when I had running the test but I forgot to add in GIT...
Problem fix now.
| $appResult->expects($this->once())->method('debug'); | ||
|
|
||
| $influxd= new Influxdump($runner); | ||
| $influxd->setup(['pathToInfluxDb' => PHPBU_TEST_BIN]); |
There was a problem hiding this comment.
pathToInfluxDb should be pathToInfluxdump
| $appResult->expects($this->once())->method('debug'); | ||
|
|
||
| $influxd = new Influxdump($runner); | ||
| $influxd->setup(['pathToInfluxDb' => PHPBU_TEST_BIN]); |
There was a problem hiding this comment.
pathToInfluxDb should be pathToInfluxdump
angelfs
force-pushed
the
feat/source-influxdb
branch
from
c6754e7
to
5c4c9ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.