Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of mysqldump restore #216

Merged
merged 5 commits into from Oct 16, 2019

Conversation

@rhorber
Copy link
Contributor

rhorber commented Oct 7, 2019

Follow up of #212 (which was closed unintentionally).

@rhorber

This comment has been minimized.

Copy link
Contributor Author

rhorber commented Oct 10, 2019

@sebastianfeldmann Would it make sense / bring some advantage to gather the common options/parameters in a MysqlCommon Executable, as a trait or abstract class? Despite some de-duplicated code. But I think the code creating the executables would not change.

@rhorber rhorber closed this Oct 10, 2019
@rhorber

This comment has been minimized.

Copy link
Contributor Author

rhorber commented Oct 10, 2019

Hit the button by accident (While writing the above comment). Sorry.

@rhorber rhorber reopened this Oct 10, 2019
@sebastianfeldmann sebastianfeldmann self-assigned this Oct 10, 2019
@sebastianfeldmann

This comment has been minimized.

Copy link
Owner

sebastianfeldmann commented Oct 10, 2019

Wow thanks. On a first glance this looks really good.
I will have a closer look at it this evening.

@sebastianfeldmann sebastianfeldmann merged commit a7d833a into sebastianfeldmann:master Oct 16, 2019
2 checks passed
2 checks passed
Scrutinizer 23 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sebastianfeldmann

This comment has been minimized.

Copy link
Owner

sebastianfeldmann commented Oct 16, 2019

Thanks a lot :)

@rhorber rhorber deleted the rhorber:feature/issue202 branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.