Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn When Using Weak Ciphers #237

Merged
merged 5 commits into from May 3, 2020
Merged

Warn When Using Weak Ciphers #237

merged 5 commits into from May 3, 2020

Conversation

moebrowne
Copy link
Contributor

@moebrowne moebrowne commented Apr 12, 2020

This PR closes #153 by adding a warning when weak ciphers are used.

@DanielRuf could you confirm the list of weak ciphers is correct?

@sebastianfeldmann
Copy link
Owner

@sebastianfeldmann sebastianfeldmann commented Apr 12, 2020

Could you move the weak algorithm handing to the Source? It feels more like an application feature than a binary/executable feature. With this change you will also eliminate the phpstan error during CI ;)

@moebrowne
Copy link
Contributor Author

@moebrowne moebrowne commented Apr 12, 2020

I think you're right, that logic doesn't belong to the Executable 👍

@moebrowne
Copy link
Contributor Author

@moebrowne moebrowne commented May 2, 2020

Any thoughts @DanielRuf?

@DanielRuf
Copy link

@DanielRuf DanielRuf commented May 2, 2020

Sorry for the late reply. So far the list of weak ciphers looks good (but personally I do not all available ciphers).

@sebastianfeldmann sebastianfeldmann merged commit 48a46d2 into sebastianfeldmann:master May 3, 2020
2 checks passed
Copy link
Owner

@sebastianfeldmann sebastianfeldmann left a comment

:)

@moebrowne moebrowne deleted the feature/weak-cipher-warning branch May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants