check_user parsing problem

[mmmurf]

https://github.com/sebastien/cuisine/blob/master/src/cuisine.py#L286

The user data is being parsed as follows:

{'shell': '/home/ubuntu', 'uid': 'x', 'passwd': '!$6$ewuA3/RZ$TQX3d5Rpusb/xIeCJ7SJ9KeNsdfsafafe qzkM.4BkCm5uIWigP.1wFei0mzovOP6lEPZ2eUx/0/', 'gid': '1000', 'home': 'Ubuntu,,,', 'name': 'sudo'}

the user is ubuntu and its home directory is /home/ubuntu

the line from /etc/password is:

ubuntu:x:1000:1000:Ubuntu,,,:/home/ubuntu:/bin/bash

[sebastien]

Hmm, I cannot reproduce this problem. Could you send the whole passwd file as a private message to see if I have the same problem? Thanks!

[dillongreen]

It's some weird message you get when /etc/hosts doesn't have the alias that is hostname. In other words you're fine if

• hostname gives you foo and your /etc/hosts contains 127.0.0.1 localhost foo
• if you only have 127.0.0.1 localhost then fabric moans about sudo which in turn triggers this check_user() bug

Here's what I quickly hacked together today:

def add_system_uuid_alias():
    """Adds system UUID alias to /etc/hosts.

    Some tools/processes rely/want the hostname as an alias in
    /etc/hosts e.g. 127.0.0.1 localhost <hostname>.

    """
    with mode_sudo(), cd('/etc'):
        old = "127.0.0.1 localhost"
        new = old + " " + get_system_uuid()
        file_update('hosts', lambda x: text_replace_line(x, old, new)[0])


def get_system_uuid():
    """Gets a machines UUID (Universally Unique Identifier)."""
    return sudo('dmidecode -s system-uuid | tr "[A-Z]" "[a-z]"')

It makes sense to have 127.0.0.1 localhost foo but then cuisine/fabric should guard against this bug anyway.

[sebastien]

Thanks, I'll integrate this!

[sebastien]

Integrated in f4dc4ba

[dillongreen]

cool, thanks... I am not sure though about the actual cause for the bug. Either way, check_user should guard against this anyhow.