New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TypeReference.HasInstance #422

Merged
merged 1 commit into from Oct 1, 2017

Conversation

Projects
None yet
2 participants
@tylerjwatson
Contributor

tylerjwatson commented Oct 1, 2017

This patch introduces support for instanceof operator on engine symbols which are created from a TypeReference. Instances constructed from a TypeReference should be an instance of that CLR type.

Traditionally, ObjectWrapper instances have no prototype, so FunctionInstance.HasInstance will always throw an error.

Tests included in InteropTests assembly. Fixes #421.

Implement TypeReference.HasInstance
 This patch introduces support for instanceof operator on engine symbols
 which are created from a TypeReference.  Instances constructed from a
 TypeReference should be an instance of that CLR type.

 Tests included in InteropTests. Fixes sebastienros/jint#421.

@sebastienros sebastienros merged commit f04109e into sebastienros:dev Oct 1, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment