New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net45 support. #530

Merged
merged 2 commits into from Sep 10, 2018

Conversation

Projects
None yet
3 participants
@ViceIce
Contributor

ViceIce commented Aug 21, 2018

Show outdated Hide outdated Jint/Jint.csproj
namespace System
{
internal static class ArrayExt

This comment has been minimized.

@sebastienros

sebastienros Sep 10, 2018

Owner

Can't we make it conditional to NET45 and use the same extension method name as netstandard? Emtpy<string>()

@sebastienros

sebastienros Sep 10, 2018

Owner

Can't we make it conditional to NET45 and use the same extension method name as netstandard? Emtpy<string>()

This comment has been minimized.

@ViceIce

ViceIce Sep 10, 2018

Contributor

This is currently not possible. There is no way to define static extension methods.

@ViceIce

ViceIce Sep 10, 2018

Contributor

This is currently not possible. There is no way to define static extension methods.

This comment has been minimized.

@ViceIce

ViceIce Sep 10, 2018

Contributor

Just for reference: dotnet/roslyn#996 😄

@ViceIce

ViceIce Sep 10, 2018

Contributor

Just for reference: dotnet/roslyn#996 😄

@lahma

This comment has been minimized.

Show comment
Hide comment
@lahma

lahma Sep 10, 2018

Collaborator

I rebased the branch and fixed some issues with the rebase, then fixed couple issues more and removed the ValueTuple dependency. Let's see how it fares in CI.

Collaborator

lahma commented Sep 10, 2018

I rebased the branch and fixed some issues with the rebase, then fixed couple issues more and removed the ValueTuple dependency. Let's see how it fares in CI.

@sebastienros sebastienros merged commit 7dbdd67 into sebastienros:dev Sep 10, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment