New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DefaultIdentifierFactory return private setter #76

Merged
merged 3 commits into from Dec 15, 2017

Conversation

Projects
None yet
2 participants
@flew2bits
Contributor

flew2bits commented Dec 14, 2017

This change allows the id accessors to set a private "Id" field on an object. This allows for the creation of immutable entities that can be rehydrated from the store since the Id property setter is no longer required to be public.

@sebastienros

This comment has been minimized.

Show comment
Hide comment
@sebastienros

sebastienros Dec 14, 2017

Owner

Can you add a unit test, or we risk to regress in the future.

Owner

sebastienros commented Dec 14, 2017

Can you add a unit test, or we risk to regress in the future.

@flew2bits

This comment has been minimized.

Show comment
Hide comment
@flew2bits

flew2bits Dec 15, 2017

Contributor

Is the added test sufficient, or do I need to perform some more assertions?

Contributor

flew2bits commented Dec 15, 2017

Is the added test sufficient, or do I need to perform some more assertions?

@sebastienros sebastienros merged commit 432b678 into sebastienros:master Dec 15, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment