Increase reads/writes in percent Error #100

Closed
leeyingmu opened this Issue Jan 3, 2014 · 3 comments

Projects

None yet

2 participants

@leeyingmu

increase_reads(/writes)_in_percent methods has one bug
I don't think the increate units calculate function is not perfect.
the code in the file table.py, 129 line and 202 line

increase = int(float(current_provisioning)*(float(percent)/100))
increase = int(float(current_provisioning)*(float(percent)/100))

If the varible current_provisioning value is 1, then the increate will always be 0, then the provisioning_units will not be increased all the time.

@sebdah sebdah was assigned Jan 3, 2014
@sebdah
Owner
sebdah commented Jan 3, 2014

Thanks for your comment. If I understand you right something like this will suffice, right?

increase = int(math.ceil(float(current_provisioning)*(float(percent)/100)))
@sebdah
Owner
sebdah commented Jan 4, 2014

This has now been released in version 1.7.1. Thanks for the report!

@sebdah sebdah closed this Jan 4, 2014
@leeyingmu

ok, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment