New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circuit breaker option bailing out w/ exception #105

Closed
mbravorus opened this Issue Jan 28, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@mbravorus

mbravorus commented Jan 28, 2014

With

Dynamic DynamoDB version: 1.7.1

if I enable circuit-breaker-url in config file like this:

circuit-breaker-url: http://some.url

(where some.url is resolvable and tested to work by wgetting), I get:

$ dynamic-dynamodb -c dydy.conf --dry-run
Traceback (most recent call last):
File "/usr/local/bin/dynamic-dynamodb", line 27, in
dynamic_dynamodb.main()
File "/usr/local/lib/python2.7/dist-packages/dynamic_dynamodb/init.py", line 136, in main
table.ensure_provisioning(table_name, table_key)
File "/usr/local/lib/python2.7/dist-packages/dynamic_dynamodb/core/table.py", line 21, in ensure_provisioning
if circuit_breaker.is_open():
AttributeError: 'module' object has no attribute 'is_open'

I was initially doubtful that this could be because of a funny URL (the one I need has query string and other funny symbols), but I then retested with a simpler URL and got the same exception

@ghost ghost assigned sebdah Jan 28, 2014

@sebdah

This comment has been minimized.

Owner

sebdah commented Jan 28, 2014

Thanks for the report I'm soon releasing a fix for this.

sebdah added a commit that referenced this issue Jan 28, 2014

sebdah added a commit that referenced this issue Jan 28, 2014

@sebdah

This comment has been minimized.

Owner

sebdah commented Jan 28, 2014

This has now been fixed in version 1.7.3. Please update and test again!

@sebdah sebdah closed this Jan 28, 2014

@mbravorus

This comment has been minimized.

mbravorus commented Jan 28, 2014

confirming as fixed, thanks!

@sebdah

This comment has been minimized.

Owner

sebdah commented Jan 28, 2014

Perfect, thank you for the error report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment