New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to turn on and off up-scaling or down-scaling #147

Closed
furio opened this Issue Apr 16, 2014 · 7 comments

Comments

Projects
None yet
3 participants
@furio

furio commented Apr 16, 2014

Kinda like #137 but with the possibility of not scaling down writes (or not scaling them up).

Alternatively, just allow 0 as percentange in up and down as "i don't want to scale up/down"

@aulisse

This comment has been minimized.

aulisse commented May 8, 2014

Hi,
also referring to #154.

I am using version 1.13

If I set "reads-lower-threshold" to 0 I got an error.
If I set "reads-lower-threshold" to 1 the script sometimes will perform autoscaling down.

Which workaround do you suggest me?

Thanks

@sebdah

This comment has been minimized.

Owner

sebdah commented May 8, 2014

  • "If I set "reads-lower-threshold" to 0 I got an error."

Yes, that's expected

  • If I set "reads-lower-threshold" to 1 the script sometimes will perform autoscaling down

What is decrease-reads-unit set to? DynamoDB should not allow you to perform a scale down at 1 unit, nor should Dynamic DynamoDB detect that a decrease is needed if this option is set to units.

@aulisse

This comment has been minimized.

aulisse commented May 9, 2014

I am currently using "decrease-reads-unit: percent"

So, using "decrease-reads-unit: unit" would solve my issue?

Thank you for your support

@sebdah

This comment has been minimized.

Owner

sebdah commented May 12, 2014

Well, not really. The functionality you are talking about is not implemented (this issue is about writing that function).

If you set

reads-lower-threshold: 1
decrease-reads-unit: units

You will not get then behaviour you described ("* If I set "reads-lower-threshold" to 1 the script sometimes will perform autoscaling down*"). But it will only tell Dynamic DynamoDB that 1 is the lowest amount of reads that you will ever want to have. That you got decreases when having reads-lower-threshold set to percent is expected as DynamoDB allows you to set limits <1% of the total provisioning.

@aulisse

This comment has been minimized.

aulisse commented May 16, 2014

May be I could use "--run-once" and "num-read-checks-before-scale-down: 2".
This should completely avoid down scaling, because on each new run of the script the counter will be reset to 0, so it's impossible that it will arrive to 2. Correct?

Thanks

@sebdah

This comment has been minimized.

Owner

sebdah commented May 16, 2014

Seems reasonable, give it a try.

sebdah added a commit that referenced this issue Jun 23, 2014

Changed from "disable" to "enable" #147
Better config file consistancy

@sebdah sebdah modified the milestones: 1.18.x, Feature request pool Jun 23, 2014

@sebdah sebdah self-assigned this Jun 23, 2014

sebdah added a commit that referenced this issue Jun 23, 2014

sebdah added a commit that referenced this issue Jun 23, 2014

@sebdah

This comment has been minimized.

Owner

sebdah commented Jun 23, 2014

This has now been implemented. Further testing needed before release. The new controls will be called:

  • enable-reads-up-scaling
  • enable-reads-down-scaling
  • enable-writes-up-scaling
  • enable-writes-down-scaling
  • enable-reads-autoscaling

I have scheduled this for release in 1.18.0 which will be released during this week.

@sebdah sebdah closed this Jun 23, 2014

@sebdah sebdah reopened this Jun 23, 2014

@sebdah sebdah closed this Jul 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment