New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSI consecutive read/write checks stuck at 1 #206

Closed
davidjwalter opened this Issue Oct 7, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@davidjwalter

davidjwalter commented Oct 7, 2014

After setting the option "num-write-checks-before-scale-down" to 3, the GSI is never updated because the consecutive write checks appears to be stuck at the value 1:

INFO - scorehistory - GSI: scoreProfileID-timeQuantum-index - Consecutive write checks 1/3

The above is logged in every check interval. On code inspection, found what appears to be a cut-paste error in init.py. In the below code, CHECK_STATUS['tables'][table_name]['reads'] should be replaced by CHECK_STATUS['gsis'][gsi_name]['reads']. Similar for writes.

    for gsi_name, gsi_key in sorted(gsi_names):
            try:
                gsi_num_consec_read_checks = \
                    CHECK_STATUS['tables'][table_name]['reads']
            except KeyError:
                gsi_num_consec_read_checks = 0

            try:
                gsi_num_consec_write_checks = \
                    CHECK_STATUS['tables'][table_name]['writes']
            except KeyError:
                gsi_num_consec_write_checks = 0

@sebdah sebdah added this to the 1.19.x milestone Oct 9, 2014

@sebdah sebdah self-assigned this Oct 9, 2014

@sebdah

This comment has been minimized.

Owner

sebdah commented Oct 9, 2014

Thank you for the report. I'll look into this and I aim to release a new version today.

@sebdah

This comment has been minimized.

Owner

sebdah commented Oct 10, 2014

This is blocked by #207 at the moment. #207 is waiting for AWS to roll out their new release to all regions, which should be done early next week.

@davidjwalter

This comment has been minimized.

davidjwalter commented Oct 13, 2014

OK. For the record, I patched 1.18.5 with the change indicated in the issue description above and it fixed the problem with GSI's.

@sebdah

This comment has been minimized.

Owner

sebdah commented Oct 13, 2014

Super, thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment