Circuit breaker return code #292

Closed
zar1 opened this Issue Apr 18, 2016 · 3 comments

Projects

None yet

3 participants

@zar1
zar1 commented Apr 18, 2016

In order to determine whether or not the circuit breaker is open, dynamic-dynamodb checks whether or not the circuit-breaker-url returns status code 200. For my service, a healthy endpoint returns 204, rather than 200. So, according to HTTP standards, the request is a success, but according to dynamic-dynamodb the service is offline. I believe it would make more sense if any 2xx status code signified success.

@sebdah sebdah added this to the 2.3.x milestone Jul 16, 2016
@sebdah sebdah self-assigned this Jul 16, 2016
@sebdah
Owner
sebdah commented Jul 16, 2016

Released in 2.3.0

@sebdah sebdah closed this Jul 16, 2016
@mbravorus
mbravorus commented Aug 2, 2016 edited

this commit destroys circuit breaker functionality completely due to an error in line 73 in circuit_breaker.py, condition should be >= 200, not > 200

see https://github.com/sebdah/dynamic-dynamodb/blob/6d67579c2bacdcf467a00564269684ecc1f99e66/dynamic_dynamodb/core/circuit_breaker.py

should I open a new issue for this?

@sebdah
Owner
sebdah commented Aug 3, 2016

@mbravorus Embarrassing! Thanks for reporting this. I'm shipping version 2.3.1 right now, where this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment