New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing to a minimum provisioned throughput value doesn't take into account the current table's throughput #45

Closed
alxmrtn opened this Issue Jun 5, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@alxmrtn

alxmrtn commented Jun 5, 2013

Say for instance I have a table with a write throughput of 2, and in my configuration, that table's minimum write throughput is set to 5. When attempting to increase to that minimum write throughput, amazon will throw an error, because you can only increase table's throughput up to twice the amount of the current throughput. Might I suggest something along the lines of:

return min( get_table_option(table_name, 'min_provisioned_reads'), (current_provisioning * 2) )
return min( get_table_option(table_name, 'min_provisioned_writes'), (current_provisioning * 2) )

When returning a minimum provisioned read or write value so that the table can at least get closer to it's minimum provisioned value.

I suppose this is an edge case, but I'd rather give you the option to ignore it instead of the issue never being heard.

@sebdah

This comment has been minimized.

Owner

sebdah commented Jun 6, 2013

Hi, @alxmrtn! Thanks for the bug report. I am on a trip to Berlin at the moment. Will have a look at this during the weekend!

@ghost ghost assigned sebdah Jun 6, 2013

sebdah added a commit that referenced this issue Jun 6, 2013

@sebdah

This comment has been minimized.

Owner

sebdah commented Jun 6, 2013

I have addressed this in a fix now. The fix has not yet been tested, but it is available in the hotfix/1.3.3 branch. Will release 1.3.3 during the weekend!

@sebdah

This comment has been minimized.

Owner

sebdah commented Jun 8, 2013

This has now been fixed and shipped with version 1.3.3. Thanks again for the feedback @alxmrtn

@sebdah sebdah closed this Jun 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment