An attempt to update provisioning is made even if the requested values are equal to the tables current values #46

Closed
alxmrtn opened this Issue Jun 12, 2013 · 2 comments

Projects

None yet

2 participants

@alxmrtn
alxmrtn commented Jun 12, 2013

If "always-decrease-rw-together" is set to true, there is a chance for the requested provisioning change to be set to that of the current tables. Because of that among other reasons... there are times when a request is made to change a tables provisioning to the same values it is currently provisioned.

In the "update_throughput" function in "dynamic-dynamodb/core/init.py" I would recommend a simple check that determines if the requested provisioning values are both equal to the current provisioning values.

This snippet would do nicely around line 305-306 in the aforementioned file:

if read_units == table.read_units && write_units == table.write_units:
    return
@sebdah sebdah was assigned Jun 13, 2013
@sebdah
Owner
sebdah commented Jun 13, 2013

Thanks for the report again @alxmrtn . And also thanks for the good suggested fixes :).

I have just released Dynamic DynamoDB 1.3.4 which addresses this issue.

@sebdah sebdah closed this Jun 13, 2013
@alxmrtn
alxmrtn commented Jun 13, 2013

@sebdah anytime! glad I can help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment