Create a table defaults section to allow multiple tables to have the same default values #181

Merged
merged 2 commits into from Jun 2, 2014

Projects

None yet

3 participants

@millarm
Contributor
millarm commented May 23, 2014

And refactor duplicated code

@millarm
Contributor
millarm commented May 23, 2014

I didn't like repeating myself in the configuration file. :-)

@sebdah
Owner
sebdah commented May 23, 2014

That's a cool feature :). Thanks for the PR. Will test it and merge it.

@sebdah sebdah added this to the 1.15.x milestone May 23, 2014
@sebdah sebdah self-assigned this May 23, 2014
@Jofen
Contributor
Jofen commented May 23, 2014

I was thinking of the same thing. Nice feature! :)

Another thing I find is I usually use the same auto scaling rules (i.e. when to scale up/down, how many percentages to scale up/down) for all tables, but just the min/max provisioning for each table is different. The thing I was thinking about is we can separate the scaling rules from table configurations, so tables can share those rulesets.
Also, in that way, we can allow multiple scaling rules per single table. The autoscaling rules can also be simplified as such:
reads last: 5.minutes, greater_than: "90%", scale: { on: :provisioned, by: 2.0 }
reads last: 10.minutes, greater_than: "70%", scale: { on: :provisioned, by: 1.5 }

Just some thoughts to share with. :)

@sebdah sebdah added a commit that referenced this pull request Jun 2, 2014
@sebdah s/tabledefaults/table_defaults/g #181 ffd8f34
@sebdah sebdah added a commit that referenced this pull request Jun 2, 2014
@sebdah Fixed too long lines #181 57029bf
@sebdah sebdah added a commit that referenced this pull request Jun 2, 2014
@sebdah Updated default section title in example #181 bae72a5
@sebdah sebdah added a commit that referenced this pull request Jun 2, 2014
@sebdah Added table_defaults support for GSIs #181 df49cb7
@sebdah sebdah added a commit that referenced this pull request Jun 2, 2014
@sebdah Changed table_defaults to default_options #181 557b3af
@sebdah sebdah merged commit 96e4a10 into sebdah:master Jun 2, 2014
@sebdah
Owner
sebdah commented Jun 2, 2014

Thanks again for the PR. I have now merged and released it in 1.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment