Allow configurable lookback period instead of the hardcoded 5 minute one #261

Merged
merged 5 commits into from Sep 30, 2015

Projects

None yet

2 participants

@Sazpaimon
Contributor

This should hopefully solve #259 however I'm unsure if having lookback-window-start have a minimum of 1 is a good idea, as you usually won't get much data between now()-1 and now(), maybe something like a minimum of 3 would be better so we can guarantee that we would have CloudWatch data. Let me know and I'll change it.

@sebdah sebdah added this to the 2.1.x milestone Sep 11, 2015
@sebdah sebdah self-assigned this Sep 11, 2015
@sebdah
Owner
sebdah commented Sep 11, 2015

Thanks again for your PR. I'm gonna read it though and release it in 2.1.0.

Let me think also about the minimum. My experience is also that setting it to 1 does not give any really good / predictable results.

@sebdah sebdah added a commit that referenced this pull request Sep 30, 2015
@sebdah Add #261 to the release notes c039ef9
@sebdah sebdah merged commit 6539d91 into sebdah:master Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment