Make circuit breaker a per-table/gsi config option #276

Merged
merged 3 commits into from Oct 23, 2015

Projects

None yet

2 participants

@Sazpaimon
Contributor

Additionally send the table and/or gsi as headers to the circuit breaker URL. This should allow users to implement per-table/gsi behavior without needing to change their configs at all.

@Sazpaimon
Contributor

I made this in response to the discussion in #236, also because my use case involves having monthly time-series tables that are created a couple days ahead of time with their operational throughputs. I wanted to configure the circuit breaker to NOT autoscale those tables until they begin accepting writes. I also didn't want to disable allow-scaling-down-reads/writes-on-0-percent because I wanted to have the ability to scale down the previous month's table down after it stops being used.

@Sazpaimon
Contributor

@sebdah I hate to be that guy, but any chance you can look at this?

@sebdah
Owner
sebdah commented Oct 23, 2015

@Sazpaimon No problem, it's me being way too slow in the responses. Having crazy times at work trying to wrap up two of our largest projects for the year.

This looks good to me, the only thing I'd like to have before merging and releasing would be documentation. Could you please add that and I'll go a head and merge and release it?

@Sazpaimon
Contributor

Done!

@sebdah
Owner
sebdah commented Oct 23, 2015

Slightly faster than me :). I'll get this merged and released during the day!

@sebdah sebdah self-assigned this Oct 23, 2015
@sebdah sebdah added a commit that referenced this pull request Oct 23, 2015
@sebdah Add release notes for #276 84a64c6
@sebdah sebdah merged commit c85ba5f into sebdah:master Oct 23, 2015
@sebdah
Owner
sebdah commented Oct 23, 2015

Thanks for this @Sazpaimon. It's now released in version 2.2.0.

Sorry again for the late response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment