More structured UI #27

Merged
merged 5 commits into from Dec 26, 2012

Conversation

Projects
None yet
2 participants
Contributor

gutschmidt commented Dec 26, 2012

Schema (keyspaces, column families) now easier to look at. Especially if it's growing large.

Schema
cassie1

Cluster
cassie2

css/style.css
@@ -188,8 +192,7 @@ select {
}
#cluster_info {
- width: 500px;
- padding-top: 10px;
+ width: 100% - 50px;
@sebgiroux

sebgiroux Dec 26, 2012

Owner

don't use space between - and 50px :)

css/style.css
@@ -233,7 +236,7 @@ a, a:visited {
.composite_value b {color:blue;}
#keyspaces {
- width: 500px;
+ width: 100% - 50px;
@sebgiroux

sebgiroux Dec 26, 2012

Owner

same here

views/cluster_info.php
+<?php echo $error_message; ?>
+
+<?php
+if ($_GET['nav'] == "cluster") {
@sebgiroux

sebgiroux Dec 26, 2012

Owner

use alternative syntax in views to be consistent with the rest, also single quotes for string and this should probably be a sub view

views/cluster_info.php
<?php
$nb_ks = count($keyspaces_name);
for ($i = 0; $i < $nb_ks; $i++):
+ if ($i/2 == intval($i/2)) {
@sebgiroux

sebgiroux Dec 26, 2012

Owner

alternative syntax here too

+
+ <br /><br />
+
+ <table width="100%" class="table table-bordered table-striped kcfs">
<?php
$nb_ks = count($keyspaces_name);
for ($i = 0; $i < $nb_ks; $i++):
@sebgiroux

sebgiroux Dec 26, 2012

Owner

It's probably missing logic after this for loop for when the last line is incomplete, the td should be colspan="2" and the tr should be closed

Owner

sebgiroux commented Dec 26, 2012

I like it, I can merge after the code changes has been made :)

FlashySearch added some commits Dec 26, 2012

Contributor

gutschmidt commented Dec 26, 2012

cool that you like it (because I like it, too ;) ). Made the changes to the files. :)

Owner

sebgiroux commented Dec 26, 2012

You're very efficient :) Good work, thanks for this, keep them coming!

sebgiroux added a commit that referenced this pull request Dec 26, 2012

@sebgiroux sebgiroux merged commit 9334654 into sebgiroux:master Dec 26, 2012

Owner

sebgiroux commented Dec 26, 2012

Btw, I get a Notice: Undefined index: nav in \CassandraClusterAdmin\views\cluster_info.php on line 12

if ($_GET['nav'] == 'cluster'):

should be replaced with:

if (isset($_GET['nav']) && $_GET['nav'] == 'cluster'):

Feel free to add notice error level to your PHP config :)

Contributor

gutschmidt commented Dec 26, 2012

You're right. I just don't use that in my own applications because it doesn't stop them from working ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment