Sebastian Markbåge sebmarkbage

Organizations

@mootools @facebook @calyptus @Instagram @reactjs
sebmarkbage commented on pull request facebook/react-devtools#81
@sebmarkbage

Sorry for letting this sit. This is really high value. We don't need to treat it as a plugin. I think we need to update the copyright headers to us…

sebmarkbage commented on issue facebook/react#3932
@sebmarkbage

Technically it is still there, just moved a level deeper. Feel free to update the hack. Checkout ReactInstanceHandles. In fact, Relay is even using…

sebmarkbage commented on issue babel/babel-eslint#95
@sebmarkbage

This is only ok when you use var since let and const would not allow you to use duplicate declarations.

sebmarkbage commented on pull request facebook/react#3586
@sebmarkbage

The benefits are that A) it works with unchanged syntax and any caller, not just JSX. B) it shows indirections. The downside is that you don't get …

sebmarkbage commented on pull request facebook/react#3586
@sebmarkbage

@spicyj Here's a kind of related thought: If you have a properly inferred name on the render function. E.g. ES6 classes would have a name like "MyC…

sebmarkbage commented on issue facebook/react#3877
@sebmarkbage

Btw, any reason you're stuck at React 0.12.2 and not upgraded to 0.13 yet?

sebmarkbage commented on issue facebook/react#3877
@sebmarkbage

I think it should work if you have global React or a global require that is able to require('react') from global scope.

sebmarkbage commented on issue facebook/react#3877
@sebmarkbage

What do you mean? You can't use the React Developer Tools to debug the extension? What kind of extension is it? Did you use the chrome://inspect to…

@sebmarkbage
Crazy Idea: Deprecate JSXText?
@sebmarkbage
sebmarkbage merged pull request facebook/react#3866
@sebmarkbage
Reorganize Src Directory for Isomorphic React Package
1 commit with 138 additions and 51 deletions
@sebmarkbage
  • @sebmarkbage 0b063f8
    Reorganize Src Files for Isomorphic React Package
@sebmarkbage
  • @sebmarkbage 32fd92b
    Reorganize Src Files for Isomorphic React Package
@sebmarkbage
sebmarkbage commented on pull request facebook/react#3866
@sebmarkbage

yes. Also lets server rendering use a different implementation.

sebmarkbage commented on pull request facebook/react#3719
@sebmarkbage

shipit

sebmarkbage commented on pull request facebook/react#3332
@sebmarkbage

Fix travis and then ship it?

sebmarkbage commented on pull request facebook/react#3651
@sebmarkbage

Seems like this whole first class function paradigm is making this slower and more complicated than it needs to be if we were just willing to dupli…

sebmarkbage commented on pull request facebook/react#3839
@sebmarkbage

No, there are also React ART Components, React Native Components etc. This is also not verifying that it is indeed a component at all, any random o…

sebmarkbage commented on pull request facebook/react#3866
@sebmarkbage

Fixed lint. Now passing travis.

@sebmarkbage
  • @sebmarkbage bd07e74
    Reorganize Src Files for Isomorphic React Package
sebmarkbage commented on pull request facebook/react#3866
@sebmarkbage

The new folder structure is best reviewed at: https://github.com/sebmarkbage/react/tree/coreapi/src

sebmarkbage commented on pull request facebook/react#3866
@sebmarkbage

For my own notes. There are some unfortunate dependencies from /isomorphic right now that we should resolve. ReactCurrentOwner.js - Needed for refs…

@sebmarkbage
sebmarkbage commented on pull request facebook/react#3822
@sebmarkbage

How will this work in partial Web Components environment? E.g. some partial polyfill where web components might extend HTMLUnknownElement? Does one…

sebmarkbage commented on pull request facebook/react#3870
@sebmarkbage

I told you, you were the king of error design.

sebmarkbage commented on issue facebook/react#3853
@sebmarkbage

We don't have an exposed way to extend the built-in event system. Essentially the problem is that these extensions wouldn't be scoped to a componen…

sebmarkbage commented on issue facebook/react#3867
@sebmarkbage

One issue was with regard to subtrees. It is not enough for subtree rendering so we introduced the subtree rendering for implicit context pass thro…

sebmarkbage commented on issue facebook/react#3865
@sebmarkbage

cc @spicyj - designer of error messages.