.clearHorizontalNav div gets duplicated easily #6

Closed
rachelbaker opened this Issue Aug 29, 2012 · 3 comments

Comments

Projects
None yet
2 participants
@rachelbaker
Contributor

rachelbaker commented Aug 29, 2012

Thank you for all of your work on HorizontalNav, it is a great menu script. I often use HorizontalNav in conjunction with another js script like TinyNav and I found that when the window is resized the div .clearHorizontalNav gets created with each resize.
See screenshot here: http://cl.ly/image/363Y2L15411i

This looks to be a result of the append('<div class="clearHorizontalNav">'); not running only if it doesn't already exist.

@sebnitu

This comment has been minimized.

Show comment Hide comment
@sebnitu

sebnitu Aug 29, 2012

Owner

Thank you for finding this! Should be an easy fix, will definitely patch it on the next update.

Owner

sebnitu commented Aug 29, 2012

Thank you for finding this! Should be an easy fix, will definitely patch it on the next update.

@rachelbaker

This comment has been minimized.

Show comment Hide comment
@rachelbaker

rachelbaker Aug 29, 2012

Contributor

I submitted my fix in a pull request here: #7

Again, thanks for your work on this!

Contributor

rachelbaker commented Aug 29, 2012

I submitted my fix in a pull request here: #7

Again, thanks for your work on this!

@sebnitu

This comment has been minimized.

Show comment Hide comment
@sebnitu

sebnitu Aug 29, 2012

Owner

Awesome, thank you for the fix! Much appreciated :D

Owner

sebnitu commented Aug 29, 2012

Awesome, thank you for the fix! Much appreciated :D

@sebnitu sebnitu closed this Aug 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment