arbitrary JSON file disclosure correction

sebsauvage · sebsauvage · commit 41df300cf06a · 2013-02-22T09:27:18.000+01:00
The following securit issue has been fixed: #30
diff --git a/index.php b/index.php
@@ -268,7 +268,7 @@ function deletePaste($pasteid)
 if (!empty($_SERVER['QUERY_STRING']))  // Display an existing paste.
 {
     $dataid = $_SERVER['QUERY_STRING'];
-    if (preg_match('/[a-f\d]{16}/',$dataid))  // Is this a valid paste identifier ?
+    if (preg_match('/\A[a-f\d]{16}\z/',$dataid))  // Is this a valid paste identifier ?
     {
         $filename = dataid2path($dataid).$dataid;
         if (is_file($filename)) // Check that paste exists.

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ function deletePaste($pasteid)`
`268`	`268`	`if (!empty($_SERVER['QUERY_STRING'])) // Display an existing paste.`
`269`	`269`	`{`
`270`	`270`	`$dataid = $_SERVER['QUERY_STRING'];`
`271`		`- if (preg_match('/[a-f\d]{16}/',$dataid)) // Is this a valid paste identifier ?`
	`271`	`+ if (preg_match('/\A[a-f\d]{16}\z/',$dataid)) // Is this a valid paste identifier ?`
`272`	`272`	`{`
`273`	`273`	`$filename = dataid2path($dataid).$dataid;`
`274`	`274`	`if (is_file($filename)) // Check that paste exists.`