RFE: add 64-bit LoongArch support #356

yetist · 2021-11-05T07:04:36Z

LoongArch is a new instruction set of Loongson 3A5000 CPU, you can read the documents or visit the development community to get more infomation.

Now I porting the libseccomp to support loongarch64, please review, thanks.

The test results of make check: make-check-main.log

drakenclimber · 2021-11-05T17:35:24Z

I haven't had a chance to look through the patches yet; I'll likely get to them next week.

The DCO check is failing because the commits don't have a Signed-off-by: tag. See other commits to libseccomp for an example. Here's the thought process behind a signed-off tag if you haven't worked with them before:
https://developercertificate.org/

coveralls · 2021-11-05T17:38:09Z

Coverage: 89.724% (+0.01%) from 89.71% when pulling c01c4fd on loongarch64:dev-main into 73be05e on seccomp:main.

pcmoore · 2021-11-05T19:53:09Z

Building upon what @drakenclimber already said, we have a CONTRIBUTING.md doc which describes the DCO and other important requirements for submitting patches to this project.

yetist · 2021-11-06T09:40:14Z

The results of make check:

Regression Test Summary
 tests run: 4693
 tests skipped: 121
 tests passed: 4693
 tests failed: 0
 tests errored: 0

The results of (cd tests; ./regression -T live):

Regression Test Summary
 tests run: 11
 tests skipped: 0
 tests passed: 5
 tests failed: 6
 tests errored: 0

Failed tests:

Test 20-live-basic_die%%003-00001 result:   FAILURE 20-live-basic_die 1 ERRNO rc=38
Test 24-live-arg_allow%%001-00001 result:   FAILURE 24-live-arg_allow 1 ALLOW rc=161
Test 44-live-a2_order%%001-00001 result:   FAILURE 44-live-a2_order 1 ALLOW rc=1
Test 51-live-user_notification%%001-00001 result:   FAILURE 51-live-user_notification 5 ALLOW rc=14
Test 54-live-binary_tree%%001-00001 result:   FAILURE 54-live-binary_tree 1 ALLOW rc=161
Test 58-live-tsync_notify%%001-00001 result:   FAILURE 58-live-tsync_notify 6 ALLOW rc=14

yetist · 2021-12-03T02:53:05Z

After updating the kernel, the tests passed:

Regression Test Summary
 tests run: 4693
 tests skipped: 121
 tests passed: 4693
 tests failed: 0
 tests errored: 0
============================================================
PASS: regression
=============
1 test passed
=============

Regression Test Summary
 tests run: 11
 tests skipped: 0
 tests passed: 11
 tests failed: 0
 tests errored: 0

The full logs are as follows:

check-syntax.log
make-check.log
regression.log

drakenclimber · 2022-01-05T15:38:42Z

Regression Test Summary
 tests run: 4693
 tests skipped: 121
 tests passed: 4693
 tests failed: 0
 tests errored: 0
============================================================
PASS: regression
=============
1 test passed
=============

Regression Test Summary
 tests run: 11
 tests skipped: 0
 tests passed: 11
 tests failed: 0
 tests errored: 0

@yetist, just to be clear - are these results from running the tests on loongarch?

pcmoore · 2022-01-05T22:57:49Z

Also, it doesn't appear that support for the LoongArch architecture has been accepted into Linus' tree yet, is this correct?

While we are always happy to add new processor architectures to libseccomp, the architecture must first be present in the mainline Linux Kernel.

yetist · 2022-01-06T07:05:22Z

@yetist, just to be clear - are these results from running the tests on loongarch?

Yes.

yetist · 2022-01-06T07:06:41Z

While we are always happy to add new processor architectures to libseccomp, the architecture must first be present in the mainline Linux Kernel.

Thank you for your reply, let's wait for the kernel.

drakenclimber · 2022-01-10T15:28:29Z

Thanks, @yetist. I briefly looked through these changes last week, and they looked good to me.

Ping us once the LoongArch changes are in the kernel, and we can work on getting this into libseccomp.

xen0n · 2022-04-25T05:17:12Z

Rebased on top of current main branch; tests passed locally, but @yetist please confirm they're still up to date as of 2.5.4.

The LoongArch patch is generated by diffing the original release tarball with the dist tarball, made with the LoongArch support PR [1] applied. Tests have passed on amd64 and loong. [1]: seccomp/libseccomp#356 Signed-off-by: WANG Xuerui <xen0n@gentoo.org>

pcmoore · 2022-04-25T19:39:54Z

Just a note to myself, as of v5.18-rc4 LoongArch does not appear to be present in the upstream Linux Kernel.

The LoongArch patch is generated by diffing the original release tarball with the dist tarball, made with the LoongArch support PR [1] applied. Tests have passed on amd64 and loong. [1]: seccomp/libseccomp#356 Signed-off-by: WANG Xuerui <xen0n@gentoo.org>

The LoongArch patch is generated by diffing the original release tarball with the dist tarball, made with the LoongArch support PR [1] applied. Tests have passed on amd64 and loong. [1]: seccomp/libseccomp#356 See: gentoo#25189 Signed-off-by: WANG Xuerui <xen0n@gentoo.org>

yetist · 2022-10-28T11:23:01Z

@drakenclimber

Done.

drakenclimber

Thanks for your hard work and patience, @yetist. Looks good to me.

Acked-by: Tom Hromatka <tom.hromatka@oracle.com>

drakenclimber · 2022-11-01T14:17:38Z

FYI - @yetist, there's still a small test failure in test 6:

Test 06-sim-actions%%005-00001 result:   FAILURE bpf_sim resulted in KILL

yetist · 2022-11-07T08:01:37Z

FYI - @yetist, there's still a small test failure in test 6:
Test 06-sim-actions%%005-00001 result:   FAILURE bpf_sim resulted in KILL

Maybe fstatfs failed on the x86_64?

yetist · 2022-11-28T04:14:36Z

The test result on the LoongArch machine:

Regression Test Summary                                                          
 tests run: 5061                                                                 
 tests skipped: 123                                                              
 tests passed: 5061                                                              
 tests failed: 0                                                                 
 tests errored: 0                                                                
============================================================                     
PASS: regression                                                                 
=============                                                                    
1 test passed                                                                    
=============

yetist · 2022-11-30T01:33:24Z

@pcmoore @drakenclimber

Please review this PR again, thanks.

drakenclimber · 2023-01-19T22:03:25Z

The latest changes look good to me. Thanks for you patience, @yetist.

Acked-by: Tom Hromatka <tom.hromatka@oracle.com>

RevySR · 2023-01-31T11:15:39Z

When will this patch be merged?

pcmoore · 2023-02-01T21:51:17Z

My apologies, I have been very busy lately. I hope to get to this within the next week or two; I will update the comments when it it merged or if I have any additional comments/questions.

Thank you for your patience.

pcmoore

I think this looks pretty good, just two very minor questions - I think once we answer/resolve those this should be ready to merge.

src/arch-syscall-validate

Signed-off-by: Xiaotian Wu <wuxiaotian@loongson.cn> Signed-off-by: WANG Xuerui <git@xen0n.name>

Signed-off-by: Xiaotian Wu <wuxiaotian@loongson.cn>

Signed-off-by: Xiaotian Wu <wuxiaotian@loongson.cn> Signed-off-by: WANG Xuerui <git@xen0n.name>

pcmoore

Hi @yetist, thanks for making those changes! I sat down this afternoon expecting to merge this PR and while running the tests on x86_64 I saw a couple of failures :( It looks like CI wasn't running on this PR so you wouldn't have noticed them if you've only been testing on LoongArch, but I believe that is fixed now so future changes should be tested via the CI.

If you can fixup these two failures (see my comments for how to fix them) I think we'll be all set. Thanks for your patience and persistence with this PR!

pcmoore · 2023-02-12T21:34:28Z

tests/06-sim-actions.tests

@@ -12,7 +12,7 @@ test type: bpf-sim
 06-sim-actions	all		write		1		0x856B008	N	N	N	N	ERRNO(1)
 06-sim-actions	all		close		4		N		N	N	N	N	TRAP
 06-sim-actions	all		openat		0		0x856B008	4	N	N	N	TRACE(1234)
-06-sim-actions	all		fstat		N		N		N	N	N	N	KILL_PROCESS
+06-sim-actions	all		fstatfs		4		0x856B008	N	N	N	N	KILL_PROCESS
 06-sim-actions	all		rt_sigreturn	N		N		N	N	N	N	LOG
 06-sim-actions	x86		0-2		N		N		N	N	N	N	KILL
 06-sim-actions	x86		7-107		N		N		N	N	N	N	KILL


Previously the test used fstat which has a syscall number of 108 on x86, hence the tests only go up to 107 on x86; with the test now using fstatfs, which is 100 on x86` this test line needs to be updated.

There is a similar issue below with x86_64 with fstat being 108 and fstatfs being 100.

tests/06-sim-actions.c

[xen0n: LoongArch (and a few upcoming architectures / ABIs) does not have fstat, so the fstat in 06-sim-actions is also being changed to fstatfs for uniformity across the board.] Signed-off-by: Xiaotian Wu <wuxiaotian@loongson.cn> Signed-off-by: WANG Xuerui <git@xen0n.name>

Signed-off-by: Xiaotian Wu <wuxiaotian@loongson.cn>

xen0n · 2023-02-13T04:02:36Z

@yetist is busy today so I'm helping to fix the tests after talking to him. Tests now pass on both x86_64 and loongarch64:

# x86_64 make check
Regression Test Summary
 tests run: 7871
 tests skipped: 84
 tests passed: 7871
 tests failed: 0
 tests errored: 0

# x86_64 live tests
Regression Test Summary
 tests run: 11
 tests skipped: 0
 tests passed: 11
 tests failed: 0
 tests errored: 0

# loongarch64 make check
Regression Test Summary
 tests run: 5061
 tests skipped: 124
 tests passed: 5061
 tests failed: 0
 tests errored: 0

# loongarch64 live tests
Regression Test Summary
 tests run: 11
 tests skipped: 0
 tests passed: 11
 tests failed: 0
 tests errored: 0

Thank you all for all the work and reviews!

yetist · 2023-02-14T02:39:53Z

@yetist is busy today so I'm helping to fix the tests after talking to him. Tests now pass on both x86_64 and loongarch64:

# x86_64 make check
Regression Test Summary
 tests run: 7871
 tests skipped: 84
 tests passed: 7871
 tests failed: 0
 tests errored: 0

# x86_64 live tests
Regression Test Summary
 tests run: 11
 tests skipped: 0
 tests passed: 11
 tests failed: 0
 tests errored: 0

# loongarch64 make check
Regression Test Summary
 tests run: 5061
 tests skipped: 124
 tests passed: 5061
 tests failed: 0
 tests errored: 0

# loongarch64 live tests
Regression Test Summary
 tests run: 11
 tests skipped: 0
 tests passed: 11
 tests failed: 0
 tests errored: 0

Thank you all for all the work and reviews!

Nice, thanks.

pcmoore

This looks good to me, thanks again everyone!

pcmoore · 2023-02-19T03:14:22Z

I've merged this into the main branch at 7179ff3, thanks for all the work and patience that went into this!

yetist mentioned this pull request Nov 5, 2021

Add loongarch64 support loongarch64-archive/libseccomp#2

Closed

yetist force-pushed the dev-main branch from 5b5e3be to ee2cb48 Compare November 5, 2021 07:15

pcmoore changed the title ~~Add 64-bit LoongArch support~~ RFE: add 64-bit LoongArch support Nov 5, 2021

pcmoore added enhancement priority/medium labels Nov 5, 2021

yetist force-pushed the dev-main branch from ee2cb48 to 126d89a Compare November 6, 2021 06:19

yetist force-pushed the dev-main branch from 126d89a to 5b4ba10 Compare December 3, 2021 02:16

yetist mentioned this pull request Mar 10, 2022

Add loongarch support loongarch64-archive/systemd#4

Merged

xen0n mentioned this pull request Mar 29, 2022

add support for loongarch64 NetworkConfiguration/dhcpcd#93

Merged

xen0n force-pushed the dev-main branch from 5b4ba10 to 5283a03 Compare April 25, 2022 05:09

yetist force-pushed the dev-main branch from cafd0d5 to 6f4b7d7 Compare October 23, 2022 06:43

drakenclimber approved these changes Oct 31, 2022

View reviewed changes

yetist force-pushed the dev-main branch from d2a29be to a9da86e Compare November 28, 2022 04:02

pcmoore added the pending/review label Feb 4, 2023

pcmoore reviewed Feb 6, 2023

View reviewed changes

src/arch-syscall-validate Outdated Show resolved Hide resolved

src/arch-syscall-validate Outdated Show resolved Hide resolved

pcmoore added pending/revision and removed pending/review labels Feb 6, 2023

yetist added 3 commits February 8, 2023 18:05

syscalls: update to Linux v6.0

d3a9f7c

Signed-off-by: Xiaotian Wu <wuxiaotian@loongson.cn> Signed-off-by: WANG Xuerui <git@xen0n.name>

tests: add fstatfs() syscall in the 06-sim-actions

8b6c8a1

Signed-off-by: Xiaotian Wu <wuxiaotian@loongson.cn>

arch: Add 64-bit LoongArch support

6dcb9d7

Signed-off-by: Xiaotian Wu <wuxiaotian@loongson.cn> Signed-off-by: WANG Xuerui <git@xen0n.name>

yetist force-pushed the dev-main branch from a9da86e to 37810a6 Compare February 8, 2023 10:07

pcmoore requested changes Feb 12, 2023

View reviewed changes

xen0n force-pushed the dev-main branch from 37810a6 to 604b567 Compare February 13, 2023 03:45

yetist added 2 commits February 13, 2023 11:52

doc: update README and manpage for 64-bit LoongArch

c01c4fd

Signed-off-by: Xiaotian Wu <wuxiaotian@loongson.cn>

xen0n force-pushed the dev-main branch from 604b567 to c01c4fd Compare February 13, 2023 03:54

pcmoore approved these changes Feb 19, 2023

View reviewed changes

pcmoore closed this Feb 19, 2023

pcmoore added this to the v2.6.0 milestone Feb 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RFE: add 64-bit LoongArch support #356

RFE: add 64-bit LoongArch support #356

yetist commented Nov 5, 2021

drakenclimber commented Nov 5, 2021

coveralls commented Nov 5, 2021 •

edited

pcmoore commented Nov 5, 2021

yetist commented Nov 6, 2021

yetist commented Dec 3, 2021

drakenclimber commented Jan 5, 2022

pcmoore commented Jan 5, 2022

yetist commented Jan 6, 2022

yetist commented Jan 6, 2022

drakenclimber commented Jan 10, 2022

xen0n commented Apr 25, 2022

pcmoore commented Apr 25, 2022

yetist commented Oct 28, 2022

drakenclimber left a comment

drakenclimber commented Nov 1, 2022

yetist commented Nov 7, 2022

yetist commented Nov 28, 2022

yetist commented Nov 30, 2022

drakenclimber commented Jan 19, 2023

RevySR commented Jan 31, 2023

pcmoore commented Feb 1, 2023

pcmoore left a comment

pcmoore left a comment

pcmoore Feb 12, 2023

pcmoore Feb 12, 2023

xen0n commented Feb 13, 2023 •

edited

yetist commented Feb 14, 2023

pcmoore left a comment

pcmoore commented Feb 19, 2023

RFE: add 64-bit LoongArch support #356

RFE: add 64-bit LoongArch support #356

Conversation

yetist commented Nov 5, 2021

drakenclimber commented Nov 5, 2021

coveralls commented Nov 5, 2021 • edited

pcmoore commented Nov 5, 2021

yetist commented Nov 6, 2021

yetist commented Dec 3, 2021

drakenclimber commented Jan 5, 2022

pcmoore commented Jan 5, 2022

yetist commented Jan 6, 2022

yetist commented Jan 6, 2022

drakenclimber commented Jan 10, 2022

xen0n commented Apr 25, 2022

pcmoore commented Apr 25, 2022

yetist commented Oct 28, 2022

drakenclimber left a comment

Choose a reason for hiding this comment

drakenclimber commented Nov 1, 2022

yetist commented Nov 7, 2022

yetist commented Nov 28, 2022

yetist commented Nov 30, 2022

drakenclimber commented Jan 19, 2023

RevySR commented Jan 31, 2023

pcmoore commented Feb 1, 2023

pcmoore left a comment

Choose a reason for hiding this comment

pcmoore left a comment

Choose a reason for hiding this comment

pcmoore Feb 12, 2023

Choose a reason for hiding this comment

pcmoore Feb 12, 2023

Choose a reason for hiding this comment

xen0n commented Feb 13, 2023 • edited

yetist commented Feb 14, 2023

pcmoore left a comment

Choose a reason for hiding this comment

pcmoore commented Feb 19, 2023

coveralls commented Nov 5, 2021 •

edited

xen0n commented Feb 13, 2023 •

edited