Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless _RADIUSAttrPacketListField class #1409

Merged
merged 1 commit into from May 11, 2018

Conversation

@p-l-
Copy link
Member

commented May 11, 2018

This class was useless since PacketListField does the job, moreover it
was buggy and could cause Scapy to go in a infinite loop. Test case
added.

Fixes #1407.

Remove useless _RADIUSAttrPacketListField class
This class was useless since PacketListField does the job, moreover it
was buggy and could cause Scapy to go in a infinite loop. Test case
added.
@codecov-io

This comment has been minimized.

Copy link

commented May 11, 2018

Codecov Report

Merging #1409 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1409      +/-   ##
==========================================
+ Coverage   85.15%   85.17%   +0.01%     
==========================================
  Files         174      174              
  Lines       40162    40149      -13     
==========================================
- Hits        34201    34195       -6     
+ Misses       5961     5954       -7
Impacted Files Coverage Δ
scapy/layers/eap.py 91.95% <100%> (+0.09%) ⬆️
scapy/layers/radius.py 97.69% <100%> (-0.15%) ⬇️
scapy/fields.py 91.35% <0%> (+0.08%) ⬆️
scapy/layers/ntp.py 91.77% <0%> (+0.26%) ⬆️
scapy/autorun.py 87.93% <0%> (+4.31%) ⬆️

@guedou guedou merged commit 905c80d into secdev:master May 11, 2018

3 checks passed

codecov/project 85.17% (+0.01%) compared to 0e9c8eb
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@p-l- p-l- deleted the p-l-:fix-radius branch May 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.