Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix OSPF LSA list dissection #751
In the PacketListField constructor, inside the OSPF_LSUpd class, an empty list was passed as argument. This resulted into strange behaviour, leading to the LSA list being displayed and managed as a raw set of bytes.
Substituting the empty list with None let the PacketListField constructor create its own empty list, resulting with the dissection process working as expected.
@@ Coverage Diff @@ ## master #751 +/- ## ========================================== - Coverage 80.29% 79.55% -0.75% ========================================== Files 138 137 -1 Lines 33939 33845 -94 ========================================== - Hits 27251 26925 -326 - Misses 6688 6920 +232
I did it but I don't know how to test it. I just used another existing file as a template, testing single commands on the Scapy interactive interface, so it should work. The previous code was not able do dissect the OSPF_Router_LSA field, while with the fix proposed everything should be accessible and now seen as "Raw".
If you could confirm it this work or where it should be fixed, if needed, then I would really appreciate it.
Thanks in advance!