#4932 fix @mention being displayed twice if the name has a TM symbol #4957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akleshchev
approved these changes
Nov 10, 2025
marchcat
approved these changes
Nov 10, 2025
akleshchev
reviewed
Nov 10, 2025
| if (!mCanEdit) | ||
| { | ||
| // Emoji shouldn't split the segment with the mention. | ||
| mPermitsEmoji = false; |
Contributor
There was a problem hiding this comment.
That's probably valid for any special segment, be that a segment with special highligts, icons or a link.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only mentions use highlight background style (determine via
getDrawHighlightBg()), so let's alter only that segments.