Skip to content

Conversation

@RyeMutt
Copy link
Contributor

@RyeMutt RyeMutt commented Nov 27, 2025

Description

Optimizes post process rendering of GLTF material preview to remove unnecessary effects.

Related Issues

  • Please link to a relevant GitHub issue for additional context.
    • Bug Fix: Link to an issue that includes reproduction steps and testing guidance.
    • Feature/Enhancement: Link to an issue with a write-up, rationale, and requirements.

Issue Link:


Checklist

Please ensure the following before requesting review:

  • I have provided a clear title and detailed description for this pull request.
  • If useful, I have included media such as screenshots and video to show off my changes.
  • The PR is linked to a relevant issue with sufficient context.
  • I have tested the changes locally and verified they work as intended.
  • All new and existing tests pass.
  • Code follows the project's style guidelines.
  • Documentation has been updated if needed.
  • Any dependent changes have been merged and published in downstream modules
  • I have reviewed the contributing guidelines.

Additional Notes

Copy link
Contributor

@cosmic-linden cosmic-linden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably do without DoF and FXAA, but iirc exposure did help in some cases to improve the visibility of the material.

What is the motivation for this change? Is this for code cleanup? On the performance front, LLGLTFPreviewTexture::render should ideally not be rendering every frame, only when needed.

@RyeMutt
Copy link
Contributor Author

RyeMutt commented Dec 1, 2025

Motivation was code cleanup to reduce the complexity of the material preview render. I can revert the exposure changes but ideally would like to eliminate DoF and FXAA as they're both relatively heavy post process passes that have little benefit here.

@cosmic-linden
Copy link
Contributor

@RyeMutt That sounds reasonable.

Signed-off-by: Rye <rye@alchemyviewer.org>
@RyeMutt RyeMutt force-pushed the rye/gltfpreviewopt branch from 0e12b0f to 53bd5fd Compare December 1, 2025 18:58
@RyeMutt
Copy link
Contributor Author

RyeMutt commented Dec 1, 2025

I tweaked it to not remove the exposure pass but did eliminate the screen space reflection copy as that also has no benefit here.

Copy link
Contributor

@cosmic-linden cosmic-linden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@akleshchev akleshchev requested a review from Geenz December 1, 2025 22:12
@akleshchev akleshchev merged commit ec8dc90 into secondlife:develop-linux Dec 1, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimizes post process rendering of GLTF material preview to remove unnecessary effects.

3 participants