#5086 Fix 'Copy SLURL' generating obsolete http link #5091
Merged
+45
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchcat
approved these changes
Dec 2, 2025
akleshchev
force-pushed
the
andreyk/viewer_5086
branch
2 times, most recently
from
af37336 to
58737b3
Compare
maxim-productengine
approved these changes
Dec 2, 2025
akleshchev
force-pushed
the
andreyk/viewer_5086
branch
from
58737b3 to
c4b4386
Compare
At least while watchdog is enabled it's more fair to label these as unknowns
akleshchev
force-pushed
the
andreyk/viewer_5086
branch
from
c4b4386 to
90815ad
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that it's needs extra testing to make sure nothing else was expecting http from affected code, but transition to https should happen one way or another.