Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyvor talk initial setup #5355

Merged
merged 11 commits into from Dec 4, 2021
Merged

Hyvor talk initial setup #5355

merged 11 commits into from Dec 4, 2021

Conversation

hborrelli1
Copy link
Contributor

@hborrelli1 hborrelli1 commented Dec 3, 2021 •
edited

  • Add Hyvor Comments and article likes.
  • Conditionally render comments based on unleash feature toggle and browser cookie.
  • Create featureToggle.js to house feature toggle logic.

https://section.tpondemand.com/entity/16311-add-hyvor-script-to-article-page

mwickman
mwickman approved these changes Dec 3, 2021
View reviewed changes
Copy link

@mwickman mwickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired together on some of this, LGTM

@hborrelli1 hborrelli1 merged commit 1e64d13 into master Dec 4, 2021
@hborrelli1 hborrelli1 deleted the hyvor-talk-initial-setup branch December 4, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwickman mwickman mwickman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hborrelli1 @mwickman