From 0bde7d06f9eab45f67d17fd5c50641f058758c81 Mon Sep 17 00:00:00 2001 From: Root <175176948+RKNF404@users.noreply.github.com> Date: Tue, 24 Dec 2024 16:51:59 -0500 Subject: [PATCH 1/5] chore: rewrite some flag names --- patches/expose-flags.patch | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/patches/expose-flags.patch b/patches/expose-flags.patch index 4a6de43f..12780a8f 100644 --- a/patches/expose-flags.patch +++ b/patches/expose-flags.patch @@ -10,7 +10,7 @@ index 9d0181f447a1a..8e10017c678f9 100644 + "Shows punycode for IDN domains to mitigate IDN homograph attacks. " + "Disabled by default. This feature is provided by hardened-chromium.", + kOsAll, FEATURE_VALUE_TYPE(url::kShowPunycodeDomains)}, -+ {"disable-cross-origin-referrers", "Clear cross-origin referrers", ++ {"clear-cross-origin-referrers", "Clear cross-origin referrers", + "Clears referrers when navigating across origins. Disabled by default. " + "This feature is provided by hardened-chromium.", kOsAll, + FEATURE_VALUE_TYPE(net::features::kDisableCrossOriginReferrers)}, @@ -32,11 +32,11 @@ index 9d0181f447a1a..8e10017c678f9 100644 + "Hides the profile icon in the toolbar in regular profiles. Enabled " + "by default. This feature is provided by hardened-chromium." , kOsAll, + FEATURE_VALUE_TYPE(features::kHideProfileIcon)}, -+ {"disable-internal-page-jit", "Disable Internal Page Jit", ++ {"internal-page-jit", "Disable Internal Page Jit", + "Disable JIT for JavaScript and WASM on internal pages & extensions. " + "Enabled by default. This feature is provided by hardened-chromium.", -+ kOsAll, FEATURE_VALUE_TYPE(features::kDisableInternalPageJit)}, -+ {"enable-gssapi", "Enable GSSAPI Authentication", ++ kOsAll, FEATURE_VALUE_TYPE(features::kEnableInternalPageJit)}, ++ {"gssapi-support", "GSSAPI Authentication", + "Enables GSSAPI for authentication. WARNING! This can cause the " + "network service sandbox to become persistently disabled, enable only " + "if absolutely necessary. This switch is provided by hardened-chromium.", From 1c97f290bbeef284a5081c0bb0d89b4963d554f3 Mon Sep 17 00:00:00 2001 From: Root <175176948+RKNF404@users.noreply.github.com> Date: Tue, 24 Dec 2024 16:54:09 -0500 Subject: [PATCH 2/5] chore: rename JIT flag --- patches/disable-jit-for-internal-pages.patch | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/patches/disable-jit-for-internal-pages.patch b/patches/disable-jit-for-internal-pages.patch index 816b7880..b3808c0f 100644 --- a/patches/disable-jit-for-internal-pages.patch +++ b/patches/disable-jit-for-internal-pages.patch @@ -10,7 +10,7 @@ index e5ce608907f72..09159a4e83115 100644 - if (!site_url.SchemeIsHTTPOrHTTPS()) + // Disable JIT for non-web schemes. + if (!site_url.SchemeIsHTTPOrHTTPS()) { -+ if (base::FeatureList::IsEnabled(features::kDisableInternalPageJit)) ++ if (!base::FeatureList::IsEnabled(features::kEnableInternalPageJit)) + return true; return false; + } @@ -25,8 +25,8 @@ index 2d95d5e1df911..e7a29a6687a07 100644 namespace features { -+BASE_FEATURE(kDisableInternalPageJit, "DisableInternalPageJit", -+ base::FEATURE_ENABLED_BY_DEFAULT); ++BASE_FEATURE(kDisableInternalPageJit, "EnableInternalPageJit", ++ base::FEATURE_DISBLED_BY_DEFAULT); + // All features in alphabetical order. @@ -48,7 +48,7 @@ index a69dcd3b24015..2f6f3d9265bbf 100644 namespace features { -+CONTENT_EXPORT BASE_DECLARE_FEATURE(kDisableInternalPageJit); ++CONTENT_EXPORT BASE_DECLARE_FEATURE(kEnableInternalPageJit); + // BEFORE MODIFYING THIS FILE: If your feature is only used inside content/, add // your feature in `content/common/features.h` instead. From ed50d2a20aae3006cc409bbdeb2c5a93cda1c212 Mon Sep 17 00:00:00 2001 From: Root <175176948+RKNF404@users.noreply.github.com> Date: Tue, 24 Dec 2024 16:54:28 -0500 Subject: [PATCH 3/5] fix: dumb --- patches/disable-jit-for-internal-pages.patch | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patches/disable-jit-for-internal-pages.patch b/patches/disable-jit-for-internal-pages.patch index b3808c0f..064223b8 100644 --- a/patches/disable-jit-for-internal-pages.patch +++ b/patches/disable-jit-for-internal-pages.patch @@ -25,7 +25,7 @@ index 2d95d5e1df911..e7a29a6687a07 100644 namespace features { -+BASE_FEATURE(kDisableInternalPageJit, "EnableInternalPageJit", ++BASE_FEATURE(kEnableInternalPageJit, "EnableInternalPageJit", + base::FEATURE_DISBLED_BY_DEFAULT); + // All features in alphabetical order. From bb131d4dbaa4f29f53464da3975e23527f512b57 Mon Sep 17 00:00:00 2001 From: Root <175176948+RKNF404@users.noreply.github.com> Date: Tue, 24 Dec 2024 16:56:27 -0500 Subject: [PATCH 4/5] fix: dumb part 2 --- patches/disable-jit-for-internal-pages.patch | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patches/disable-jit-for-internal-pages.patch b/patches/disable-jit-for-internal-pages.patch index 064223b8..5599930d 100644 --- a/patches/disable-jit-for-internal-pages.patch +++ b/patches/disable-jit-for-internal-pages.patch @@ -26,7 +26,7 @@ index 2d95d5e1df911..e7a29a6687a07 100644 namespace features { +BASE_FEATURE(kEnableInternalPageJit, "EnableInternalPageJit", -+ base::FEATURE_DISBLED_BY_DEFAULT); ++ base::FEATURE_DISABLED_BY_DEFAULT); + // All features in alphabetical order. From 98114cc29570c0e42d8fa36e87da336aff5c6777 Mon Sep 17 00:00:00 2001 From: Root <175176948+RKNF404@users.noreply.github.com> Date: Tue, 24 Dec 2024 16:57:24 -0500 Subject: [PATCH 5/5] chore: adjust wording --- patches/expose-flags.patch | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/patches/expose-flags.patch b/patches/expose-flags.patch index 12780a8f..dd78625d 100644 --- a/patches/expose-flags.patch +++ b/patches/expose-flags.patch @@ -32,9 +32,9 @@ index 9d0181f447a1a..8e10017c678f9 100644 + "Hides the profile icon in the toolbar in regular profiles. Enabled " + "by default. This feature is provided by hardened-chromium." , kOsAll, + FEATURE_VALUE_TYPE(features::kHideProfileIcon)}, -+ {"internal-page-jit", "Disable Internal Page Jit", -+ "Disable JIT for JavaScript and WASM on internal pages & extensions. " -+ "Enabled by default. This feature is provided by hardened-chromium.", ++ {"internal-page-jit", "Internal Page Jit", ++ "Toggle JIT for JavaScript and WASM on internal pages & extensions. " ++ "Disabled by default. This feature is provided by hardened-chromium.", + kOsAll, FEATURE_VALUE_TYPE(features::kEnableInternalPageJit)}, + {"gssapi-support", "GSSAPI Authentication", + "Enables GSSAPI for authentication. WARNING! This can cause the "